fix: interactive styles on secondary button inside a ButtonGroup #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sirineJ, Thanks! |
🦋 Changeset detectedLatest commit: c68b717 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sirineJ
force-pushed
the
fix/hover-effects-in-button-group
branch
from
a6aa77f
to
6b601c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1938 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 172 172
Lines 3565 3565
Branches 1198 1198
=======================================
Hits 3269 3269
Misses 275 275
Partials 21 21
|
connor-baer
reviewed
Feb 6, 2023
sirineJ
force-pushed
the
fix/hover-effects-in-button-group
branch
from
6b601c2
to
c68b717
Compare
connor-baer
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937
Purpose
Fix observed wrong styles on secondary action inside a
<ButtonGroup/>Approach and changes
Override secondary button styles in the SecondaryButton
Definition of done